The pack where I was Cubmaster up until 2 years ago just sold Christmas wreaths. The 50-60 cubs would sell about 1100 wreaths, and we would end up with about $6,500-$7,500 profit.
My current Troop used to just sell Popcorn, but of the 30% of the sales that the troop received, only 5% was kept in the troop coffers. The remaining 25% was credited to the scouts. They would also charge about $150 for annual registration.
Given the success of wreath sales at my former pack, I convinced the Committee to do a trial wreath sale this last year. We only ended up with about 160 wreaths pre-ordered, but when I ended up being forced to accept 325 wreaths (it was my fault for being optimistic) the scouts ended up selling all but 11 of them. Even after eating the 11 that didn't get sold, and donating 4 to the CO, we banked about $1,100 for the troop, and $1,250 was credited to individual scouts.
There was something of a motivation problem with the sale this year. Out of our 50 active scouts, about 80% of the sales were done by less than 12 boys and half didn't sell more than 2. I think the problem is that since most of the families are fairly wealthy, and simply pay for every camp-out for their son; the boys don't have much incentive to sell.
After discussing it with a few of the scouts that didn't bother to sell, I've decided that I will need to put together a prize list for next year. I will basically offer a selection of good quality hunt/fish/camp gear as an alternative to just getting "credit" in the scout account ledger.